Extensions#76
Merged
Merged
Conversation
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the beginning of the package, we have naturally wanted to extend the functionalities to GridapP4est and GridapPETSc. However, this comes at a cost: We now depend on compatibility with the binaries/artifacts that power those two packages. This has been a downside in terms of compatibility, as showcased by the struggles we had during our JOSS publication. Moreover, the library has come to a point where we do not require PETSc or P4est for most things.
All this considered, I have decided to move all of this code to extensions. Extensions are a new feature of Julia 1.9, that allow conditional loading and extension of packages. This perfectly addresses our needs, so I see no downside of taking this path.
The only downside is that it limits our Julia compat to 1.9 and above. I however do not think this is an issue.